[Feature][RayJob] Remove wget dependency in Sidecar GCS wait#4468
Open
400Ping wants to merge 12 commits intoray-project:masterfrom
Open
[Feature][RayJob] Remove wget dependency in Sidecar GCS wait#4468400Ping wants to merge 12 commits intoray-project:masterfrom
400Ping wants to merge 12 commits intoray-project:masterfrom
Conversation
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
400Ping
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
win5923
reviewed
Feb 4, 2026
Signed-off-by: 400Ping <jiekaichang@apache.org>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
4 tasks
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
win5923
reviewed
Feb 13, 2026
…switch tests Signed-off-by: 400Ping <jiekaichang@apache.org>
Contributor
Author
Done |
win5923
reviewed
Feb 13, 2026
Member
There was a problem hiding this comment.
Wait a minute, we actually don’t need to care about which Ray image version is being used. Since we are checking RayDashboardGCSHealthPath, this endpoint exists both before and after 2.53.0 version. We can therefore simplify this by replacing wget with Python’s urllib.
400Ping
changed the title
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
400Ping
changed the title
Contributor
Author
|
cc @JiangJiaWei1103 @yuhuan130 to take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RayJob Sidecar mode waits for Ray Dashboard GCS health before submitting jobs.
That wait loop previously depended on
wget.Some Ray images may not include
wget, which can cause Sidecar submission startup failures before job submission begins.Since this check targets
api/gcs_healthz(available across Ray versions used here) and Sidecar submitter already depends on Python (rayCLI), we can remove thewgetdependency by using Pythonurllibdirectly.Change summary
RayJob Sidecar mode
wgetto Pythonurllib.until ... sleep 2 ...).Tests
2.53.02.52.1Out of scope
Related issue number
Closes #3837
Checks